Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode implementation - Fixed Post PR Changes Part 1 #4860

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Dark mode implementation - Fixed Post PR Changes Part 1 #4860

merged 3 commits into from
Jan 31, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jan 26, 2023

Explanation

Dark mode implementation - Fixed Post PR Changes Part 1

This PR changes following Dark Mode Post PR :-

  1. Remove component_color_shared_text_view_text_color and color_palette_secondary_text_colorand use other defined text colors.
  2. Check all drawable,colors,styles files to make sure that we are using component_colors only.
  3. Remove ‘component_color_shared_content_item_text_view_color’ as we have ‘component_color_shared_primary_text_color’
  4. Remove ‘ToolbarTitle’ and use ‘ToolbarTextAppearance’ in titleTextAppearance for ToolBar in different xml’s files.
  5. Remove component_color_general_item_background_solid_color and component_color_general_item_background_stroke_color and general_item_border.xml
  6. Remove all other component_colors which are using color_palette_dark_text_color and only use component_color_shared_primary_dark_text_color
  7. Remove general_item_background_border_light and use general_item_background_border.
  8. Remove general_item_background_border_black

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, I make changes for Dark Mode Post PR changes as per docs.
As file changes running huge. So make it easy to review I divided this changes in 2 parts.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @MohitGupta121

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Jan 27, 2023
@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Jan 27, 2023

Thanks @rt4914
I discussed with Rajat related screenshots in Google Chat, and according to him, this PR is clear without screenshots.

@MohitGupta121
Copy link
Member Author

@BenHenning PTAL, if you have any suggestions.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. LGTM for codeowners

@BenHenning BenHenning merged commit 2f4714c into oppia:develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants