Fix #3755: Administration controls invisible but actionable #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking out the latest code in 'develop'
|
@adhiamboperes PTAL |
There was a problem hiding this comment.
Thanks @masclot!
Can you add some screenshots or a video since this is a UI issue?
|
Sure. The video shows how you can click on a hidden ui control in the current version, but you cannot after the changes in this cl.
|
adhiamboperes
approved these changes
Mar 20, 2023
|
Unassigning @adhiamboperes since they have already approved the PR. |
BenHenning
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Thanks @masclot! I agree--this is a nice find. Two things:
- Can you please move the before/after video to the PR description (under the UI section, per its instructions)?
- Can you add a test to verify that replace() is being used as expected? This test should fail if you temporarily revert back to 'replace'.
Done |
|
@BenHenning PTAL |
BenHenning
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Thanks @masclot! The PR LGTM, but can you please include a screenshot showing the test failing when the fix is temporarily reverted (just to demonstrate that it can correctly catch the issue)?
Screenshot added to the PR description |
|
@BenHenning PTAL |
BenHenning
approved these changes
Mar 30, 2023
|
Syncing with latest develop & enabling auto-merge. |
|
Unassigning @BenHenning since they have already approved the PR. |
|
Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Uticodes
pushed a commit
to Uticodes/oppia-android
that referenced
this pull request
Apr 4, 2023
…ia#4901) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix oppia#3755: AdministratorControlsActivity tablet has Fragment management issues The "App Version" fragment was being added on top of the previous fragment, instead of replacing it. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing The following videos show how you can click on a hidden ui control in the current version, but you cannot after the changes in this cl. |current|new| |-|-| |[current_administration_controls_invisible_but_actionable.webm](https://user-images.githubusercontent.com/103062089/225941610-d41ed412-625c-45de-b18c-3279bd2d2401.webm)|[new_administration_controls_invisible_but_actionable.webm](https://user-images.githubusercontent.com/103062089/225941644-7b3598ba-89c5-4a8b-9611-ecc751ea1b25.webm)| Screenshot with test failure when app-version goes back to use add fragment, instead of replace fragment.  --------- Co-authored-by: Ben Henning <ben@oppia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #3755: AdministratorControlsActivity tablet has Fragment management issues
The "App Version" fragment was being added on top of the previous fragment, instead of replacing it.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
The following videos show how you can click on a hidden ui control in the current version, but you cannot after the changes in this cl.
Screenshot with test failure when app-version goes back to use add fragment, instead of replace fragment.