Fix #4532: Prevent multiple concept card fragments

[masclot]

Explanation

Fix #4532: only allow one concept card open at a time. If the new new concept card has the same skill id as an existing one, do not open and instead reuse the existing one.

I modified a couple of concept card data for dev so that they link to each other. This change is not necessary for this PR to work, but it allows manually testing the scenario where a concept car links to another.

Current behavior:
multiple concept cards allowed, even with same skill id.webm

New behavior:
ConceptCard deduplication demo.webm

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[BenHenning]

@masclot is this ready for review or did you open the draft so that people can help with specific parts? Just wanted to make sure that we aren't inadvertently ignoring this. :)

[masclot]

@masclot is this ready for review or did you open the draft so that people can help with specific parts? Just wanted to make sure that we aren't inadvertently ignoring this. :)

It is not ready. Since the change is not trivial, I just wanted to show what my idea is, so that I get early comments. @adhiamboperes already commented on chat.

[masclot]

@adhiamboperes PTAL

[masclot]

@BenHenning PTAL

[masclot]

The error in the checks seems to be temporal:

# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x00007f02ba37d3e0, pid=2671, tid=2685

Could anybody rerun them?

[adhiamboperes]

Thanks @masclot! I took a first pass, and I'll be able to provide more specific feedback in the next pass.

• Since you've made changes to scripts/assets files , please have their rationale included in the PR explanation.
• There are some unrelated commits/changes, please remove them.

[oppiabot]

Unassigning @adhiamboperes since the review is done.

[oppiabot]

Hi @masclot, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

[masclot]

Addressed the last two conversations.
@BenHenning PTAL

[BenHenning]

Thanks @masclot! Really sorry for the delayed review here.

The PR LGTM, but had 1 nit left and I think the branch needs to be brought up-to-date with the latest develop changes. Please assign back once both are done and I'll go ahead and kick-off the merge.

[masclot]

Thanks @masclot! Really sorry for the delayed review here.

The PR LGTM, but had 1 nit left and I think the branch needs to be brought up-to-date with the latest develop changes. Please assign back once both are done and I'll go ahead and kick-off the merge.

I addressed the comment. Regarding "bringing the branch up-to-date with the latest develop changes", I'm not sure I'm doing it right. In Android Studio, I checked out my develop branch and clicked "Update" on it. I then checked-out the branch for this change and also clicked "Update". Would that be enough?

[masclot]

I don't think Android Studio -> <branch-name> -> Update does a merge. This menu is what oppia documentation says we should do in Android Studio to update our repository: https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#making-a-local-code-change-using-android-studios-ui-based-github-workflow

Instead I did the following in Android Studio:

• checkout develop
• fetch
• merge upsteam/develop
• checkout <my-branch>
• fetch
• merge develop

I hope these steps are good. Please let me know otherwise.

[BenHenning]

Thanks @masclot! Re: updating the branch, I think we have instructions in the wiki for this but I can't find them off hand at the moment (@MohitGupta121 might you know?). We generally recommend doing this via Git CLI since it's easier to "debug" when something goes wrong, and I'm less familiar with the Android Studio Git interface.

PR LGTM!

[BenHenning]

Updating to latest develop & enabling auto-merge.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!