-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4883 : Remove exempted file from Kotlin and Xml Regex components colors checks #4942
Fix Part of #4883 : Remove exempted file from Kotlin and Xml Regex components colors checks #4942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning PTAL, I make changes and remove exempted files from Regex check that we dicussed here #4882 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121! I didn't find much, just a few small things. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BenHenning, PTAL, updated the review changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, this LGTM! Approving & enabling auto-merge.
Unassigning @BenHenning since they have already approved the PR. |
Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fix Part of #4883 : Remove exempted file from Kotlin and Xml Regex components colors checks
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: