Fix #4397, #4923: Change the closing button description for consistency & gender neutral profile image

[XichengSpencer]

Fixes #4397: The closing button on the nav bar of concept card activity had inconsistent voice output, it is changed to "navigate up" for consistency.
Fixes #4923: "Have outline person as default gender-neutral image"

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes

• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide]

[adhiamboperes]

Hi @XichengSpencer. Thanks for your PR.

Can you please add a recording in the description that shows the fix is working?

Also counter-check the essential checklist and ensure your PR meets all that are applicable.

[XichengSpencer]

Here is the recording

https://user-images.githubusercontent.com/74568012/233457088-8d26b9e0-c05b-485f-8e6c-1252f76871cd.mp4
I checked all the requirements. The title now has contained the fix and issue number, and even though I cannot assign the reviewer but it appears it has automatically assigned one here. Let me know if there are any questions.

[adhiamboperes]

This looks correct.
@BenHenning, do we generally add automated tests that verify content descriptions?

[BenHenning]

Thanks @XichengSpencer!

This looks correct. @BenHenning, do we generally add automated tests that verify content dsecriptions?

@adhiamboperes @XichengSpencer Yep, we should add a test for situations that can be tested (and content descriptions generally can be). Please do add a test to verify this change @XichengSpencer.

[XichengSpencer]

For #4923 here are the result screenshots

[adhiamboperes]

Hey @XichengSpencer. I would advise that you open one PR per issue that you are working on, for now.

[XichengSpencer]

Hey @XichengSpencer. I would advise that you open one PR per issue that you are working on, for now.

Sorry, I forgot to create a new branch for this one. I will definitely keep it in mind for the next time. But what should I do for this one? The second issue is just a minor resource change here.

[adhiamboperes]

Hey @XichengSpencer. I would advise that you open one PR per issue that you are working on, for now.

Sorry, I forgot to create a new branch for this one. I will definitely keep it in mind for the next time. But what should I do for this one? The second issue is just a minor resource change here.

We can keep this one this time, although in future only close multiple issues in one PR if they are thematically related.

[adhiamboperes]

Thanks @XichengSpencer. Your changes look good to me.

Can you also fill out the screenshots section of the PR description and then assign your pr over to Ben by tagging him and mentioning "PTAL"?

[XichengSpencer]

Thanks @XichengSpencer. Your changes look good to me.

Can you also fill out the screenshots section of the PR description and then assign your pr over to Ben by tagging him and mentioning "PTAL"?

Done. Thank you so much for the review!

[XichengSpencer]

Hi @BenHenning
Changes have been made, PTAL. Thank you!

[oppiabot]

Unassigning @XichengSpencer since a re-review was requested. @XichengSpencer, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Thanks @XichengSpencer! This LGTM from a code perspective.

@seanlip could you or someone from UX weigh in on the icon change before we finalize this & merge?

[seanlip]

Hm, I'm a bit dubious about the new icon. I'm a bit unsure about using the outline version instead of the filled version.

Let me ask the design team for some feedback -- stay tuned. I'll send an email.

[seanlip]

Assigning to @kaiyuxu (Android design lead) for feedback.

[BenHenning]

Thanks @XichengSpencer. Waiting on the design team's feedback before approving in case there are any additional changes needed.

[seanlip]

@BenHenning Confirming this is all fine from a design and product perspective (see email) -- let's get this in. Thanks!

[BenHenning]

Thanks @seanlip for confirming, and thanks @XichengSpencer for wrapping this up! LGTM.

[BenHenning]

Updating the PR to the latest develop & enabling auto-merge.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @XichengSpencer, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!