-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit all xml layout files for Dark Mode audit #4954
Revisit all xml layout files for Dark Mode audit #4954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning PTAL, Thanks.
Can I add screenshot for any screen?
As I not change any thing from color side, except to move Hex color of splash activity to component color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121. This looks good! I always appreciate a good clean-up. :) Thanks also for adding the extra regex check.
@MohitGupta121 given that this is just a simple refactor with no side-effects, a screenshot isn't really needed here. |
Updating PR to latest develop & enabling auto-merge. |
Thanks @BenHenning |
Unassigning @BenHenning since they have already approved the PR. |
Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Revisit all xml layout files for Dark Mode audit:
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: