Fix #4648: Fix topic lesson differentiation between locked, completed and in-progress lessons

[kkmurerwa]

Explanation

Fix #4648: When this PR is merged, it will fix the issue of locked, completed and in progress lessons not being differentiated by Talkback.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[BenHenning]

Thanks @kkmurerwa! This seems like a really sensible solution. Had a few follow-up suggestions--PTAL.

[kkmurerwa]

Screenshot(s) of the failing test when the new code block is commented out;

The log produced by the failure

Screenshot of the passing test with the new code block uncommented;

[kkmurerwa]

Hey @BenHenning. I have addressed your comments and added screenshots of the failing and passing test. You should be able to do another review. PTAL.

[kkmurerwa]

Hey @BenHenning. I have temporarily reassigned myself the issue. There are a few more changes I am working on to improve accessibility.

[kkmurerwa]

Hey @BenHenning. Here are a few changes I have made with commit ID 8d497a2.

• I noticed that there are no existing tests to check for the computeChapterPlayStateIconContentDescription that is displayed on the chapter_play_state_icon. I added a test for this that tests in the content description for progress chapters is being displayed correctly.
• In the case of a completed chapter topic, there is no chapter play state icon displayed. I modified the chapter_index text view to display the string from computeChapterPlayStateIconContentDescription instead for better Talkback feedback to visually impaired users.
• I added a test for the computeChapterPlayStateIconContentDescription in the case of the completed chapter topic state.

Here is a screenshot of the failing tests when I return a dummy string.

Here is a screenshot of the passing tests when the original logic is reinstated.

The tests on the CI failed for some reason but they all pass locallly. The failing test requires a rerun to pass.

[BenHenning]

Apologies @kkmurerwa will need to look at this tomorrow.

[kkmurerwa]

No problem at all Ben.

[BenHenning]

Thanks @kkmurerwa! PR LGTM, just had small nits--PTAL. Also, the branch will need to be brought up-to-date with the latest develop so that we can merge it.

[kkmurerwa]

Hey @BenHenning. The issues mentioned have been resolved. The PR should now be ready for a merge unless there are some other issues.

[BenHenning]

Thanks @kkmurerwa! Apologies for the delayed review. This LGTM!