-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use GitHub’s search feature to search the wiki #4961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning @seanlip PTAL,
In last welfare meeting I discussed the problem that we have enough infomation in wiki but contributors not able to reach it. So the solution is GitHub search feature which helps to search into wiki (I think most of the new contributors even I not know that apart from code, we also search into wiki with GitHub search feature.).
So I decied to add Gif to demostrate this feature both in oppia and oppia-android after discussing with Chris.
Also I decided to add missing TOC in oppia-android wiki page which make searcing easy.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121. Two questions:
(a) Perhaps this should be on the "Coders" page instead, since the home page is meant to be more generic for different types of volunteers? Alternatively, you can have it at the bottom of the page in a separate section ("How to find information on this wiki").
(b) You mention adding a TOC, but I don't see it?
@seanlip Thanks for review, Thanks. |
Hm, for (b), this wasn't clear from your previous comment. I can't approve it since I don't know what you are proposing exactly, but in the future I suggest making the changes you think would be best and then sending that entire PR for review -- it speeds up the process. |
Okay Thanks @seanlip, I keep this in mind and act accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlip PTAL, Thanks.
I added TOC to most of the wiki related to oppia-android codebase. But not for some general wikis such as "Our Mission", and "SLoP-2020".
If we need TOC for that wikis also please let me know.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, I generally have no concerns. Just noticed one minor thing.
wiki/Overview-of-the-Oppia-Android-codebase-and-architecture.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, LGTM!
@seanlip PTAL, replace all other Tabs to spaces. |
Unassigning @MohitGupta121 since a re-review was requested. @MohitGupta121, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121! LGTM for textproto change.
Note I didn't review the wiki files in detail since @seanlip already approved, but I can take a pass if you need me to.
Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121! The new search feature LGTM as well.
Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
@BenHenning Do I need to add new TODO issue for wiki update when GitHub new search feature release? And Will you please merge this, if nothing unresolved. Thanks! |
A TODO isn't necessary, I think. We can update this reactively as the flow on GitHub isn't changing too drastically. |
Explanation
How to use GitHub’s search feature to search the wiki
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: