Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Change: New styles for the Oppia Deprecation Dialog Design #4997

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

kkmurerwa
Copy link
Collaborator

@kkmurerwa kkmurerwa commented May 24, 2023

Explanation

The introduction of the new deprecation dialogs for the App/OS Deprecation feature led to a minor redesign of the dialogs. This includes style changes to the dialogs that will display various deprecation messages. The proposed dialogs can be seen on this Figma link. When merged, this PR will introduce the new theme needed to achieve the desired dialog designs.

The difference between the current and the proposed dialog are highlighted below

Current Design Proposed Design
A screenshot of the current deprecation dialog A screenshot of the redesigned deprecation dialog

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@kkmurerwa
Copy link
Collaborator Author

Hey @adhiamboperes. I have assigned you this PR for a preliminary review before we get to Ben. Go through it and leave some feedback.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kkmurerwa, I have requested some changes.

I suggest looking at the wiki sections for working on the UI and dark mode for more clarity on patterns.

app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
@kkmurerwa
Copy link
Collaborator Author

kkmurerwa commented May 31, 2023

Hi @adhiamboperes. I have made the suggested changes. You can take another look at it now. I have updated the PR comment at the top as well to feature the side-by-side comparison of the designs.

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa May 31, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left further comments @kkmurerwa, PTAL.

Also do respond to all current comments so that I can resolve them, thanks!

app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented May 31, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented May 31, 2023

Hi @kkmurerwa, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@BenHenning BenHenning removed their request for review June 2, 2023 03:43
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I think I forgot to request another review. I have made all the suggested changes and you can have another pass at this PR.

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Jun 2, 2023
@kkmurerwa kkmurerwa requested a review from a team as a code owner June 2, 2023 06:16
@kkmurerwa kkmurerwa requested a review from adhiamboperes June 2, 2023 06:16
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! These changes LGTM.

Please respond to all review comments so that I can resolve them before merge.

@oppiabot
Copy link

oppiabot bot commented Jun 3, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 3, 2023
@oppiabot
Copy link

oppiabot bot commented Jun 3, 2023

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I think I have responded to all conversations.

@adhiamboperes
Copy link
Collaborator

Hi @adhiamboperes. I think I have responded to all conversations.

I think you're seeing this: #4874 (comment)

@oppiabot
Copy link

oppiabot bot commented Jun 11, 2023

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Jun 11, 2023
@oppiabot
Copy link

oppiabot bot commented Jun 22, 2023

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 22, 2023
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. Should I resolve the conversation or reviews that I inadvertently started while replying to comments or should I just resolve the conversations?

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 22, 2023
Copy link
Collaborator Author

@kkmurerwa kkmurerwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the review comments.

app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
@adhiamboperes adhiamboperes enabled auto-merge (squash) June 22, 2023 11:14
@adhiamboperes adhiamboperes merged commit 329c377 into oppia:develop Jun 22, 2023
@kkmurerwa kkmurerwa deleted the new-oppia-dialog-design branch November 1, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants