Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #632: Move PromotedStoryListAdapter to BindableAdater #5077

Merged
merged 12 commits into from
Jul 11, 2023

Conversation

masclot
Copy link
Collaborator

@masclot masclot commented Jun 30, 2023

Fix #632: Move PromotedStoryListAdapter to BindableAdater

This change reverts partially #4951, which in turn reverted #4874 due to a bug.
It is a partial revert because the bug was fixed independently in the previous PR #4965.

I added RecentlyPlayedViewModel.kt to the list of classes not needing tests, as is usual for ViewModels. This was also part of the original PR.

current new
recently_played_ltr_current recently_played_ltr_new
recently_played_rtl_current recently_played_rtl_new
recently_played_ltr_landscape_current recently_played_ltr_landscape_new
recently_played_rtl_landscape_current recently_played_rtl_landscape_new

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/op
    pia/oppia-android/wiki/Accessibility-A11y-Guide))
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@masclot masclot requested review from a team as code owners June 30, 2023 14:06
@masclot masclot requested a review from adhiamboperes June 30, 2023 14:06
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masclot! This PR LGTM.

I just had one minor comment and also please add the landscape screenshots before merge.

@oppiabot oppiabot bot added the PR: LGTM label Jul 3, 2023
@oppiabot
Copy link

oppiabot bot commented Jul 3, 2023

Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 10, 2023

Hi @masclot, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 10, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 11, 2023
@masclot
Copy link
Collaborator Author

masclot commented Jul 11, 2023

I addressed the comments and added the landscape images.
PTAL @adhiamboperes

@masclot masclot assigned adhiamboperes and unassigned masclot Jul 11, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masclot, this LGTM.

@adhiamboperes adhiamboperes enabled auto-merge (squash) July 11, 2023 14:12
@oppiabot
Copy link

oppiabot bot commented Jul 11, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jul 11, 2023

Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 1862c4a into oppia:develop Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace current recyclerview implementation with BindableAdapter usage
2 participants