-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #632: Move PromotedStoryListAdapter to BindableAdater #5077
Fix #632: Move PromotedStoryListAdapter to BindableAdater #5077
Conversation
Checking out the latest code in 'develop'
Update repository
The exception is MarginBindingAdapters, which contained the bug that prompted the revert. This file was fixed in PR oppia#4965.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masclot! This PR LGTM.
I just had one minor comment and also please add the landscape screenshots before merge.
app/src/main/java/org/oppia/android/app/home/recentlyplayed/RecentlyPlayedFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Hi @masclot, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
I addressed the comments and added the landscape images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masclot, this LGTM.
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Fix #632: Move PromotedStoryListAdapter to BindableAdater
This change reverts partially #4951, which in turn reverted #4874 due to a bug.
It is a partial revert because the bug was fixed independently in the previous PR #4965.
I added RecentlyPlayedViewModel.kt to the list of classes not needing tests, as is usual for ViewModels. This was also part of the original PR.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
pia/oppia-android/wiki/Accessibility-A11y-Guide))