Lint the linter via clippy + handle/fix findings #94
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates Clippy linting into the build process via `nix flake build`,
ensuring automated code quality checks for all PRs.
This change includes:
- Fixed Clippy warnings by:
- Using `#[derive(Default)]` for OutFormat enum
- Correcting parameter references in Label creation
- Adding is_empty() method to address Clippy recommendation
- Added #[allow(clippy::borrowed_box)] annotations for cases where
fixing would require broader code changes (to be changed by further PRs)
- Updated GitHub Actions dependencies:
- actions/checkout from v3 to v4
- cachix/install-nix-action from v18 to v30 (resolves input parameter
warnings). Older versions of cachix/install-nix-action didn't yet
support the input parameter `github_access_token`.
- Modified flake.nix to include Clippy in the Rust toolchain and run it
during the check phase
|
@oppiliappan @mightyiam ready for review. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Clippy linting into the build process via
nix flake build, ensuring automated code quality checks for all PRs.This change includes:
#[derive(Default)]for OutFormat enumis_empty()method to address Clippy recommendation#[allow(clippy::borrowed_box)]annotations for cases where fixing would require broader code changes (to be changed by further PRs)actions/checkoutfrom v3 to v4cachix/install-nix-actionfrom v18 to v30 (resolves input parameter warnings). Older versions of cachix/install-nix-action didn't yet support the input parametergithub_access_token.note: I am a first time contributor to the repo, so the workflow run is awaiting for approval. A green workflow run can be seen in my fork of the repo https://github.com/dbast/statix/actions/runs/13545008940