Handle jaif for constructor with empty ASTPath #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incl. Zhou's fixes
wmdietl
reviewed
Jan 19, 2021
| @@ -310,7 +310,12 @@ private void buildClassEntries() { | |||
| // TODO: this is not a feature but a workaround of a bug: | |||
There was a problem hiding this comment.
Note that this is just a hacky work-around.
I think it would be better to fix all the places that incorrectly have an empty ASTPath. Instead of a silent continue here, we should raise an error when we still find an empty ASTPath.
Also note the duplication between the change here and the one above. Do we really need both? If so, maybe the getConstructorRecord method should be called in more places?
As discussed, please first add a test case to make sure we're fixing this error.
|
Look at relation to #129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jaif writer skips records with empty
ASTPathbut constructor records are created with an empty path thus get skipped.Updating this behaviour will allow injecting infereed annotations to constructors by including these records into generated jaif file.