Fix polymorphism check and introduce the concept of PolymorphicInstanceSlot
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
approved these changes
Feb 9, 2022
wmdietl
approved these changes
Feb 10, 2022
wmdietl
reviewed
Feb 17, 2022
settings.gradle
Outdated
| @@ -1,7 +1,7 @@ | |||
| includeBuild ('../annotation-tools/annotation-file-utilities') { | |||
| if (!file('../annotation-tools/annotation-file-utilities').exists()) { | |||
| exec { | |||
| executable '.ci-build-without-test.sh' | |||
| executable './.ci-build-without-test.sh' | |||
There was a problem hiding this comment.
Hi @zcai1 could you break out this change so that we can merge it?
It looks like https://github.com/opprop/value-inference/pull/8/files is failing for this reason, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPolymorphicQualifierwith the real type factory for constant slot.createPolymorphicInstanceSlotto slot manager since it's not really a source variable. Currently, we are using source variable slot for polymorphic instance because it doesn't affect the inference result.settings.gradlewasn't working properly under some environments.Note: This PR is related to opprop/ontology#58 since it introduces the polymorphic annotation
@Ontology(values={POLY})