Pull PICO changes #108
Closed
Pull PICO changes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingweitian
commented
Dec 18, 2019
...-test/src/main/java/org/checkerframework/framework/test/diagnostics/TestDiagnosticUtils.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
Dec 18, 2019
framework/src/main/java/org/checkerframework/framework/flow/CFAbstractTransfer.java
Show resolved
Hide resolved
xingweitian
commented
Dec 18, 2019
framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
Dec 18, 2019
| @@ -1343,7 +1348,7 @@ public void postAsMemberOf( | |||
| addAnnotationFromFieldInvariant(type, owner, (VariableElement) element); | |||
| } | |||
| addComputedTypeAnnotations(element, type); | |||
| if (viewpointAdapter != null) { | |||
| if (viewpointAdapter != null && type.getKind() != TypeKind.EXECUTABLE) { | |||
There was a problem hiding this comment.
What other uses of viewpointadapter are there in the class?
xingweitian
commented
Dec 18, 2019
framework/src/main/java/org/checkerframework/framework/type/DefaultTypeHierarchy.java
Show resolved
Hide resolved
xingweitian
commented
Dec 18, 2019
| @@ -383,6 +400,48 @@ private boolean visited(AnnotatedTypeMirror atm) { | |||
| return res; | |||
| } | |||
|
|
|||
| public AnnotationMirrorMap<AnnotationMirrorSet> reduce2( | |||
xingweitian
commented
Dec 18, 2019
| @@ -20,7 +20,6 @@ void uses() { | |||
| newTree("hello").put("bye"); | |||
|
|
|||
| MyTree<@UnknownVal String> myTree1 = newTree("hello").put("bye"); | |||
| // :: error: (assignment.type.incompatible) | |||
This reverts commit 0bfaae4
Tweak javadoc. Update method name. Improve code.
This was referenced Jan 24, 2020
|
This can be closed after @lnsun's new pull requests have been merged. |
d367wang
pushed a commit
to d367wang/checker-framework
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapted @baoruiz's branch (pull-pico-changes) to the latest CF.
Close #83
Close #74