Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visitor rule for invalid polymorphic qualifier use #204

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

zcai1
Copy link

@zcai1 zcai1 commented Feb 7, 2022

hasAnnotationRelaxed only checks whether the name of the annotation matches the name of the poly annotation. This PR proposes to use hasAnnotation instead because we could have annotations with a poly value, and hasAnnotation also compares the values of an annotation.

Note: This PR is related to opprop/ontology#58 since it introduces the polymorphic annotation @Ontology(values={POLY})

@wmdietl
Copy link
Member

wmdietl commented Feb 7, 2022

This change looks good, and I don't think it's worth writing a new type system to test this.
Once the tests pass here and work for the ontology usage, please open the same PR in eisop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants