Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the messages. #3

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Complete the messages. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/pico/typecheck/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
constructor.invocation.invalid=Cannot not instantiate type: %s out of constructor: %s
constructor.return.invalid=Invalid constructor return type: %s
method.receiver.incompatible
class.bound.invalid
subclass.bound.incompatible
method.receiver.incompatible=Incompatible method receiver: %s
class.bound.invalid=Invalid class bound: %s
subclass.bound.incompatible=Incompatible subclass bound: %s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this error raised? Should the message be similar to super.constructor.invocation.incompatible, something like Subclass bound %s is not compatible with super class bound %s?
In general I find the term "subclass" strange and we should look to clean this terminology up.
But let's do both of these improvements in separate PRs.

super.constructor.invocation.incompatible=Subclass constructor: %s is not compatible with super class constructor: %s
illegal.field.write=Cannot write field via receiver: %s
illegal.array.write=Cannot write array via receiver: %s
Expand Down