Some small tweaks. #4
Conversation
build.gradle
Outdated
| @@ -79,7 +79,7 @@ afterEvaluate { | |||
| // Create a task for each JUnit test class whose name is the same as the JUnit class name. | |||
| sourceSets.test.allJava.filter { it.path.contains("${picoPath}/src/test/java") }.forEach { file -> | |||
| String junitClassName = file.name.replaceAll(".java", "") | |||
| String testName = junitClassName.replaceAll("Test", "") | |||
| String testName = junitClassName.replaceAll("Tests", "") | |||
There was a problem hiding this comment.
In the Checker Framework the test drivers all end with Test: https://github.com/typetools/checker-framework/tree/master/checker/src/test/java/tests
So we should do the renaming from xxxTests -> xxxTest.
The corresponding code in the CF build file https://github.com/typetools/checker-framework/blob/master/build.gradle#L533
doesn't substitute names. Why is this neede?
There was a problem hiding this comment.
I think this is not mandatory to substitute names, just for showing the simple names in terminal.
I will rename it.
There was a problem hiding this comment.
After substituting names, if we execute ./gradlew tasks, we will get something like this:
Verification tasks
------------------
check - Runs all checks.
ImmutabilityInferenceTest - Run ImmutabilityInference tests.
ImmutabilityTypecheckTest - Run ImmutabilityTypecheck tests.
test - Runs the unit tests.
If we do not substitute names, it will be like:
Verification tasks
------------------
check - Runs all checks.
ImmutabilityInferenceTest - Run ImmutabilityInferenceTest tests.
ImmutabilityTypecheckTest - Run ImmutabilityTypecheckTest tests.
test - Runs the unit tests.
So I think maybe it is better to substitute names to get a better description.
|
@wmdietl Could you please have another look? |
This PR makes some changes:
ImmutabilityInferenceTestandImmutabilityTypecheckTests, now they are calledImmutabilityInferenceTestsandImmutabilityTypecheckTests.testinput/typecheck/SuperClass.java.Because they are just some small tweaks, so I guess I can put them all in a single PR. If this sounds not good, I can also separate it in three different PRs.