Workaround for the logic issue of AnnotatedTypes.asMemberOf
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d367wang
commented
May 25, 2021
d367wang
changed the title
AnnotatedTypes.asMemberOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in opprop/checker-framework-inference#310, there are some logic issues with
AnnotatedTypes.asMemberOfwhich annotates methods of a parameterized type. The VarAnno created for the parameterized type argument is missing.In this PR, a general default qualifier is specified to work around this so that if the previous annotators don't add any annotation, the default applier will add one to make sure constraints can be created.
The newly-added test file ParameterizedTypeTest.java is to ensure that the workaround works.
Identical to #49, except being named samely as opprop/checker-framework-inference#313