Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project directory implementation proposal #1678

Closed
4 of 11 tasks
samuelstroschein opened this issue Nov 21, 2023 · 2 comments
Closed
4 of 11 tasks

project directory implementation proposal #1678

samuelstroschein opened this issue Nov 21, 2023 · 2 comments
Assignees
@samuelstroschein
Labels
scope: inlang/fink-editor Related to source-code/website/editor. scope: inlang/sdk Related to source-code/sdk. scope: inlang/sherlock-vscode Related to source-code/ide-extension. type: feature New feature or request type: refactor Code being refactored to improved performance or long-term maintainability.

Comments

@samuelstroschein
Copy link
Member

samuelstroschein commented Nov 21, 2023 •
edited
Loading

📺 LOOM

Context

  • read the directory proposal here

Goal

  • complete implementation by the end of the week
  • no implicit behavior that can lead to unexpected/buggy behavior
  • no breaking behavior for apps

Tasks

  • create a project directory in loadProject with a readme that prompts the user to delete the old project.inlang.json file
  • .gitignore .prettierignore files
  • add console.warn to loadProject if .json is loaded
  • throw if a project has no name e.g. .inlang
  • major release of the inlang CLI that throws when project.inlang.json is used
  • new prerelease of paraglide js CLI that throws when project.inlang.json is used
  • update docs
  • rename projectSettingsFile to projectPath
  • avoid breaking: ide extension looks for project directory in current working directory (as it does right now with project.inlang.json)
  • avoid breaking: editor looks for project directory in current working directory (avoid breakage and postpone filepicker implementation)
  • add project.name property to a project
@samuelstroschein samuelstroschein self-assigned this Nov 21, 2023
@maige-app maige-app bot added effort: medium scope: inlang/fink-editor Related to source-code/website/editor. scope: inlang/sherlock-vscode Related to source-code/ide-extension. type: feature New feature or request labels Nov 21, 2023
@samuelstroschein samuelstroschein mentioned this issue Nov 21, 2023
Closed
@NilsJacobsen
Copy link
Contributor

I like the Readme migration guide. 👍

@samuelstroschein samuelstroschein added scope: inlang/sdk Related to source-code/sdk. type: refactor Code being refactored to improved performance or long-term maintainability. and removed effort: medium labels Nov 21, 2023
@samuelstroschein
Copy link
Member Author

implemented via #1762

This was referenced Nov 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelstroschein samuelstroschein

Labels
scope: inlang/fink-editor Related to source-code/website/editor. scope: inlang/sdk Related to source-code/sdk. scope: inlang/sherlock-vscode Related to source-code/ide-extension. type: feature New feature or request type: refactor Code being refactored to improved performance or long-term maintainability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelstroschein @NilsJacobsen