1678-project-directory #1762
Merged
1678-project-directory #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`loadProject` might write files for migration.
…{ projectPath })` to align with new project directory structure
1. we don't expect users to manually set up projects. instead, product pages will explain how to get started 2. maintaining the guide is high effort and misleading due to 1 cc @NiklasBuchfink lmk if you disagree
Not worth the effort of maintaining the guide. - only 9 views in the past 7 days - high effort keeping the guide up to date - the --project flag in the documentation of paraglide js seems self-explanatory cc @NilsJacobsen let me know if you disagree
- users get started by looking at products on inlang.com - the goal of the readme should be "go on inlang.com", not manually set up stuff - given the reasons above, maintaining this readme's getting started section seems unnecessary cc @felixhaeberle lmk if you disagree
Pretty self explanatory how plugins can be installed via inlang.com. No wall of text needed. @NilsJacobsen feedback: I would expect a "tell me why plugins are great" not a "docs" why i need plugins for stuff load and save messages (at this point i dont know what those functions do).
@NiklasBuchfink you can implement a "create new project" in fink now. No need for docs. Feedback: - the usage sections seems redundant given that fink is a GUI application (that should be self explanatory)
Clicking on install reveals the same info with less maintenance effort
🦋 Changeset detectedLatest commit: a2858e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Given that @felixhaeberle is OOO. I will fix the ide extension and CLI |
cc @felixhaeberle @openscript hacky implementation but it works. The hardcoded assumption for a project file should be
|
IDE Extension is also working now as expected CleanShot.2023-11-29.at.14.00.08.mp4 |
|
@LorisSigrist @NilsJacobsen @NiklasBuchfink can you merge this PR tomorrow morning along with the version packages PR that will shortly afterwards be opened by vchangesets? I don't want to merge the PR now and potentially break an app while you are all asleep. Reduced risk if you do it first thing tomorrow morning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 LOOM
What to review
Do your apps work? No thorough code review is expected although you can of course do that
Tasks