PAXWEB-1274 support jetty 9.4.34 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdw
changed the title
|
@jbonofre seeing that you are also active on this project, can you have a look at this pull request? And make it possible for me to merge it? Thanks in advance. |
|
I will take a look, thanks ! |
|
Ok, I made you part of the team. |
ANierbeck
approved these changes
Nov 15, 2020
jbonofre
approved these changes
Nov 16, 2020
|
I will cherry pick to the other branches. |
jbonofre
pushed a commit
that referenced
this pull request
Nov 16, 2020
* PAXWEB-1274 only set classloader if jetty context has not started yet * PAXWEB-1274 upgrade jetty from 9.4.31 to 9.4.34 Co-authored-by: Tom De Wolf <> (cherry picked from commit c3d040b)
jbonofre
pushed a commit
that referenced
this pull request
Nov 16, 2020
* PAXWEB-1274 only set classloader if jetty context has not started yet * PAXWEB-1274 upgrade jetty from 9.4.31 to 9.4.34 Co-authored-by: Tom De Wolf <> (cherry picked from commit c3d040b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ANierbeck concerns a fix for PAXWEB-1274. Please review. As mentioned on the ticket, when upgrading to the new jetty version integration tests registering filters already failed. As such tests are included that cover this change.