Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return friendly errors on file encoding violations #114

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ogenstad
Copy link
Contributor

Fixes #102

@ogenstad ogenstad force-pushed the pog-friendly-error-on-encoding-exception-IHS-52 branch 3 times, most recently from f9e99f4 to b6e64b0 Compare October 30, 2024 10:56
@ogenstad ogenstad force-pushed the pog-friendly-error-on-encoding-exception-IHS-52 branch from b6e64b0 to bcedf52 Compare October 30, 2024 11:01
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/validate.py 57.14% 2 Missing and 1 partial ⚠️
infrahub_sdk/ctl/repository.py 50.00% 1 Missing ⚠️
@@             Coverage Diff              @@
##           develop     #114       +/-   ##
============================================
+ Coverage    43.26%   64.40%   +21.13%     
============================================
  Files           74       75        +1     
  Lines         6856     6871       +15     
  Branches      1353     1359        +6     
============================================
+ Hits          2966     4425     +1459     
+ Misses        3622     2094     -1528     
- Partials       268      352       +84     
Flag Coverage Δ
python-3.10 43.42% <86.20%> (+0.16%) ⬆️
python-3.11 43.42% <86.20%> (+0.16%) ⬆️
python-3.12 43.42% <86.20%> (+0.16%) ⬆️
python-3.9 43.37% <86.20%> (+0.16%) ⬆️
python-filler-3.12 23.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/_file.py 100.00% <100.00%> (ø)
infrahub_sdk/yaml.py 78.48% <100.00%> (+7.64%) ⬆️
infrahub_sdk/ctl/repository.py 39.62% <50.00%> (+2.58%) ⬆️
infrahub_sdk/ctl/validate.py 52.85% <57.14%> (-2.08%) ⬇️

... and 42 files with indirect coverage changes

@ogenstad ogenstad marked this pull request as ready for review October 30, 2024 11:11
@ogenstad ogenstad requested a review from a team October 30, 2024 11:11
@ogenstad ogenstad merged commit b008784 into develop Oct 30, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-friendly-error-on-encoding-exception-IHS-52 branch October 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: infrahubctl should display a proper message when files have a non utf-8 encoding
2 participants