Raise 422 SchemaNotFoundError while uploading a schema referring an unexisting schemanode #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
LucasG0
force-pushed
the
lgu-clean-error-on-missing-schema-menu-placement
branch
from
1cd2dbd to
6f31bd6
Compare
…isting schemanode
LucasG0
force-pushed
the
lgu-clean-error-on-missing-schema-menu-placement
branch
from
6f31bd6 to
aa3e390
Compare
ajtmccarty
reviewed
Sep 11, 2024
| branch_name=self.name, | ||
| identifier=node.menu_placement, | ||
| message=f"{node.kind} refers an unexisting menu placement node: {node.menu_placement}.", | ||
| ) |
There was a problem hiding this comment.
can you raise this exception from the captured one please
| raise SchemaNotFoundError( | ||
| branch_name=self.name, | ||
| identifier=node.menu_placement, | ||
| message=f"{node.kind} refers an unexisting menu placement node: {node.menu_placement}.", |
There was a problem hiding this comment.
I'd say f"{node.kind} refers to an invalid menu placement node: {node.menu_placement}."
dgarros
approved these changes
Sep 12, 2024
LucasG0
deleted the
lgu-clean-error-on-missing-schema-menu-placement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4089