Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): allow id filters to be combined #4366

Closed
wants to merge 1 commit into from
Closed

fix(sdk): allow id filters to be combined #4366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions python_sdk/infrahub_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,14 +415,14 @@ async def get(
filters[schema.default_filter] = id
else:
filters["ids"] = [id]
elif hfid:
if hfid:
if isinstance(schema, NodeSchema) and schema.human_friendly_id:
filters["hfid"] = hfid
else:
raise ValueError("Cannot filter by HFID if the node doesn't have an HFID defined")
elif kwargs:
filters = kwargs
else:
if kwargs:
filters.update(kwargs)
if len(filters) == 0:
raise ValueError("At least one filter must be provided to get()")

results = await self.filters(
Expand Down Expand Up @@ -1789,14 +1789,14 @@ def get(
filters[schema.default_filter] = id
else:
filters["ids"] = [id]
elif hfid:
if hfid:
if isinstance(schema, NodeSchema) and schema.human_friendly_id:
filters["hfid"] = hfid
else:
raise ValueError("Cannot filter by HFID if the node doesn't have an HFID defined")
elif kwargs:
filters = kwargs
else:
if kwargs:
filters.update(kwargs)
if len(filters) == 0:
raise ValueError("At least one filter must be provided to get()")

results = self.filters(
Expand Down
Loading