Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Python SDK to external repository #4378

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

dgarros
Copy link
Collaborator

@dgarros dgarros commented Sep 19, 2024

Fixes #4232

This PR replaces the local python SDK with the repository opsmill/infrahub-sdk-python using a git submodule.
Moving forward all fixes related to the python SDK should be opened on the other repository

@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Sep 19, 2024
@dgarros dgarros marked this pull request as ready for review September 19, 2024 04:31
@dgarros dgarros requested review from fatih-acar and a team September 19, 2024 04:31
Copy link
Contributor

@fatih-acar fatih-acar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update documentation around git clone, we now need to initialize the submodule.

@dgarros dgarros force-pushed the dga-20240918-sdk-submmodule branch from 2b123a9 to 068a08e Compare September 19, 2024 11:52
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Sep 19, 2024
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove the jobs to run SDK tests and coverage reporting too, but that can come as the next step.

@dgarros dgarros merged commit becbcc9 into stable Sep 19, 2024
32 checks passed
@dgarros dgarros deleted the dga-20240918-sdk-submmodule branch September 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/ci Issue related to the CI pipeline type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants