Add validation for hierarchy parent and children #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
ajtmccarty
approved these changes
Sep 22, 2024
| @@ -1148,3 +1154,15 @@ async def to_graphql( | |||
| return None | |||
|
|
|||
| return await relationships[0].to_graphql(fields=fields, db=db, related_node_ids=related_node_ids) | |||
|
|
|||
| async def _validate_hierarchy(self) -> None: | |||
| if self.node._schema.is_profile_schema or not self.node._schema.hierarchy: # type: ignore[union-attr] | |||
There was a problem hiding this comment.
we should use node.get_schema in this method instead of accessing the _schema private variable
dgarros
force-pushed
the
dga-20240921-fix-4325
branch
from
6558745 to
0e4cb63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4325
Enforce the constraints defined in the schema that when a hierarchical node doesn't have a parent or children