IFC-727 calculate diff tree in proposed change pipeline

[ajtmccarty]

IFC-727
sdk PR opsmill/infrahub-sdk-python#61

• remove unit test that belongs in SDK
• add diff calculation to the proposed change pipeline

[codspeed-hq]

CodSpeed Performance Report

Merging #4546 will not alter performance

_{Comparing ajtm-10052024-diff-in-pipeline-IFC-727 (e9b34ed) with stable (bf8e85e)}

Summary

✅ 10 untouched benchmarks

[ogenstad]

I think the changes looks solid. What I don't really like is that we don't get to see that the changes will work in combination. As the Git submodule still points to a commit that doesn't include the changes you made in the SDK we wouldn't spot any errors at this point of there was anything that is wrong and it will be harder to understand why something starts to fail later.

I'm not sure how we should handle this in general.

One way would be to;

1. update the submodule commit in this PR to be that of your SDK branch in order to verify that it is working
2. merge the PR in the SDK
3. go back to this PR, either change the submodule to the current stable commit or leave it

What are your thoughts around that?

[ogenstad]

This would only update the branch diff and not in any way give us access to the diff_summary right? I'm thinking that we first do some operations directly against the database and then as the next step we use the SDK to query for the changes (which I guess would be what we updated but also what might have been updated earlier)

[ajtmccarty]

the DiffTree and DiffTreeSummary graphql queries get their data from the same place. Running update_branch_diff here will create/update that data so that both queries can be used and will be up-to-date (for the moment, at least. other stuff that runs in the pipeline can make changes that will require another update to the diff

[ajtmccarty]

I updated the python_sdk commit in this PR to point to the commit on the partner PR in the sdk repo opsmill/infrahub-sdk-python#61
when both are approved, I will merge the sdk PR, update the commit pointer on this PR to the latest sdk commit on stable, then merge this PR

[ogenstad]

LGTM. Not sure what the commit for the SDK if that should be replaced with the latest "stable" one if this is another one.