Restrict size of common string attribute kinds #4584
Conversation
github-actions
bot
added
the
group/backend
LucasG0
force-pushed
the
lgu-restrict-attribute-size
branch
2 times, most recently
from
d6da0e4 to
2671a7f
Compare
CodSpeed Performance ReportMerging #4584 will not alter performanceComparing Summary
|
LucasG0
force-pushed
the
lgu-restrict-attribute-size
branch
from
2671a7f to
292bb88
Compare
backend/infrahub/core/attribute.py
Outdated
| @classmethod | ||
| def validate_content(cls, value: Any, name: str, schema: AttributeSchema) -> None: | ||
| super().validate_content(value, name, schema) | ||
| if ATTRIBUTE_TYPES[schema.kind] in [Text, Password]: |
There was a problem hiding this comment.
I'd add URL here as well, don't think it will ever be relevant but you never know..
There was a problem hiding this comment.
I missed this one, I don't think we should hardcode the list if kinds that will be validated here, mostlikely this list will grow in the future and we'll forget about it
Might be better to have a list of kinds that are exempted from the check
There was a problem hiding this comment.
Looking closer into into it, ideally we should apply the validation to all attributes, after serialize, (except if the kind is exempted from the check)
There was a problem hiding this comment.
As discussed, added modifications to validate any non-large attribute. This is done after serializing to avoid an extra serialization.
LucasG0
force-pushed
the
lgu-restrict-attribute-size
branch
from
4f8c85a to
302f474
Compare
LucasG0
force-pushed
the
lgu-restrict-attribute-size
branch
from
302f474 to
1b038be
Compare
Would fix #4432