Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid changing optional property of inherited attributes #4940

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Forbid changing optional property of inherited attributes #4940

merged 2 commits into from
Nov 15, 2024

Conversation

gmazoyer
Copy link
Contributor

Fixes #4936

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4940 will not alter performance

Comparing gma-20241115-4936 (dd0f22c) with develop (f00a6ae)

Summary

✅ 10 untouched benchmarks

@gmazoyer gmazoyer marked this pull request as ready for review November 15, 2024 08:55
@gmazoyer gmazoyer requested a review from a team November 15, 2024 08:55
ogenstad
ogenstad approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good with a towncrier entry too.

@gmazoyer gmazoyer merged commit 8de74d6 into develop Nov 15, 2024
28 of 30 checks passed
@gmazoyer gmazoyer deleted the gma-20241115-4936 branch November 15, 2024 11:21
@dgarros
Copy link
Collaborator

dgarros commented Nov 15, 2024

would be good to cherry pick this commit in stable
good reminder that we need to make sure all bug fixes are going into stable not develop by default

@dgarros dgarros added the type/bug Something isn't working as expected label Nov 15, 2024
gmazoyer added a commit that referenced this pull request Nov 15, 2024
@gmazoyer
Forbid changing optional property of inherited attributes (#4940)
03327b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogenstad ogenstad ogenstad approved these changes

Assignees
No one assigned
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Overriding Optional between Generic and Node crash server
3 participants
@gmazoyer @dgarros @ogenstad