Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update generator guide to add convert_query_response example #5297

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Dec 22, 2024

  • Added example for convert_query_response for a generator using tabs.
  • Re-order to test the generator locally and load some data into a branch and then merge it
  • Add more content to running generator in a CI pipeline

I'm curious if we might want to just add the example into an opsmill repo that they can add to Infrahub without creating a repo, etc.

@BeArchiTek
Copy link
Contributor

We could put an example into the demo-edge repository and be able to have the image generated with our e2e tests doing the screenshot. Do you think it will add a lot of work for it ?

@FragmentedPacket
Copy link
Contributor Author

We could put an example into the demo-edge repository and be able to have the image generated with our e2e tests doing the screenshot. Do you think it will add a lot of work for it ?

I'm thinking at this point, it is probably a bit more overhead than I can take on as we'd have to make sure to use the same schema, etc. but I do think it would be a good idea to use a more relevant example and the by product also being able to not have to manually generate the screenshots.

docs/docs/guides/generator.mdx Show resolved Hide resolved
docs/docs/guides/generator.mdx Outdated Show resolved Hide resolved
@FragmentedPacket FragmentedPacket dismissed wvandeun’s stale review January 3, 2025 17:10

Addressed feedback

@FragmentedPacket FragmentedPacket merged commit e536909 into opsmill:stable Jan 3, 2025
28 checks passed
@FragmentedPacket FragmentedPacket deleted the may202412-docs-guides-generator-convert-updates branch January 3, 2025 17:10
gmazoyer pushed a commit that referenced this pull request Jan 9, 2025
…5297)

* Update generator guide to add convert_query_response and re-ordered guide.

* Add some details around convert_query_response.

* Moved created git repository to step 1 and other minor updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants