Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsfragment for computed attributes #5302

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ogenstad
Copy link
Contributor

I realised that as the computed attribute support was done it many different PRs none of them actually contained the news fragment that I'm adding now.

Fixes #3637

@ogenstad ogenstad marked this pull request as ready for review December 23, 2024 09:20
@ogenstad ogenstad requested a review from a team December 23, 2024 09:20
@dgarros
Copy link
Collaborator

dgarros commented Dec 23, 2024

@lykinsbd prepared something in #5290, not sure if we need both

@ogenstad
Copy link
Contributor Author

Ah ok. I'll leave this as if for now and we can close it if Brett doesn't need anything from it.

@ogenstad ogenstad merged commit d8131ca into release-1.1 Dec 23, 2024
26 checks passed
@ogenstad ogenstad deleted the pog-computed-attribute-news-IFC-219 branch December 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants