Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artifacts diff #5311

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix artifacts diff #5311

merged 1 commit into from
Dec 24, 2024

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Dec 23, 2024

IFC-1020
no changelog b/c this new artifact query was introduced after 1.0 and never ported back, so we only need this update in 1.1

fixes a bug in the new query for getting artifact diffs. the bug was that the query only looked for CoreArtifacts created on the source_branch, but the CoreArtifact could have been created on the target_branch (always main for now) and then updated on the source_branch. I thought this kind of handling would not be necessary because CoreArtifacts are branch=local, but I did not consider the following case for branch=local schema

  1. an artifact is created on main
  2. we create a new branch branch2
  3. the artifact generation logic makes an update to the existing artifact on branch2
    in this case, the CoreArtifact node is on the main branch, but it has updates to its attributes/relationships on the branch2 branch

added some unit tests and integration tests to cover this

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Dec 23, 2024
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #5311 will not alter performance

Comparing ajtm-12232024-artifacts-diff (a87c35a) with release-1.1 (9b2562d)

Summary

✅ 10 untouched benchmarks

@ajtmccarty ajtmccarty marked this pull request as ready for review December 23, 2024 22:42
@ajtmccarty ajtmccarty requested a review from a team December 23, 2024 22:42
@ajtmccarty ajtmccarty merged commit 5f7a674 into release-1.1 Dec 24, 2024
31 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-12232024-artifacts-diff branch December 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants