Ensure _get_entities_with_data_loader is not using the default db session #5314
+112
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5314 will not alter performanceComparing Summary
|
dgarros
force-pushed
the
dga-20241224-fix-resolver
branch
from
9adc9cc to
2ba7b3f
Compare
ajtmccarty
approved these changes
Dec 24, 2024
| result_per_name = { | ||
| result["node"]["name"]["value"]: result["node"] for result in result.data["InfraDevice"]["edges"] | ||
| } | ||
| assert sorted(result_per_name.keys()) == ["device1", "device2"] |
There was a problem hiding this comment.
might be nice to check all the data in this response while we have it
verified this passes locally
Suggested change
| assert sorted(result_per_name.keys()) == ["device1", "device2"] | |
| assert sorted(result_per_name.keys()) == ["device1", "device2"] | |
| expected_location_data = { | |
| "node": { | |
| "name": {"value": "site1"}, | |
| "devices": {"edges": [{"node": {"name": {"value": "device1"}}}, {"node": {"name": {"value": "device2"}}}]}, | |
| } | |
| } | |
| assert result.data["InfraDevice"]["edges"][0]["node"]["location"] == expected_location_data | |
| assert result.data["InfraDevice"]["edges"][1]["node"]["location"] == expected_location_data |
dgarros
force-pushed
the
dga-20241224-fix-resolver
branch
from
2ba7b3f to
96c143e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.