Separate Apache and MySQL into two containers using docker-compose. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove MySQL server and main.sh from Dockerfile - Add docker-compose.yml (Version 3) - update DVWA config to use MySQL container hostname instead of `127.0.0.1` - add apache config, and move php.ini to `conf/` directory - move images to `img/` directory while I'm at it Tested on OS X and Docker 17.09 CE
cmattoon
force-pushed
the
docker-compose
branch
from
0cb81d2 to
eaa4ede
Compare
|
Love this |
|
While this image is intended to be easy to use and, let users be able to setup everything with just one command and have no need to have docker-compose installed. I agree that splitting the services is a better practice, it can be done but it won't replace the official image. I'm created the issue #13 to keep track of the progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
127.0.0.1conf/directoryimg/directory while I'm at itTested on OS X and Docker 17.09 CE
Fixes #5