Skip to content

fix: improve emoji checking and only increase font with single emoji (issue #396 pr #97) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: improve emoji checking and only increase font with single emoji (issue #396 pr #97) #97

merged 1 commit into from
Aug 19, 2024

Conversation

DouglasKosvoski
Copy link
Member

Resolve:

Descrição:

  • Adicionado um caso no código tratar emojis mais "complexos" (são formados por vários caracteres unicode).
  • Aplica o aumento da fonte apenas quando a mensagem contém apenas um único emoji.

image

Fix: https://github.com/optidatacloud/optiwork-chat/issues/396

@DouglasKosvoski DouglasKosvoski added bug Something isn't working enhancement New feature or request labels Aug 16, 2024
@DouglasKosvoski DouglasKosvoski self-assigned this Aug 16, 2024
@DouglasKosvoski DouglasKosvoski requested a review from a team August 16, 2024 12:24
larimones
larimones approved these changes Aug 16, 2024
View reviewed changes
Copy link

@larimones larimones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adorei essa feat! ✨

@larimones larimones requested a review from a team August 16, 2024 12:28
MatheusZuchiBalbinot
MatheusZuchiBalbinot approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@MatheusZuchiBalbinot MatheusZuchiBalbinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MatheusZuchiBalbinot MatheusZuchiBalbinot requested a review from a team August 16, 2024 12:33
alissonpeloso
alissonpeloso approved these changes Aug 16, 2024
View reviewed changes
Copy link

@alissonpeloso alissonpeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa! 😍

@Dovyski Dovyski merged commit d7dfe40 into master Aug 19, 2024
arufonsekun pushed a commit that referenced this pull request Dec 3, 2024
@DouglasKosvoski @arufonsekun
fix: emoji checking only increase font with single emoji (issue advan…
e1c1c36 
…ced-chat#396, pr #97)

fix: improve emoji checking and only increase font with single emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alissonpeloso alissonpeloso alissonpeloso approved these changes

@MatheusZuchiBalbinot MatheusZuchiBalbinot MatheusZuchiBalbinot approved these changes

+1 more reviewer

@larimones larimones larimones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DouglasKosvoski DouglasKosvoski

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DouglasKosvoski @alissonpeloso @larimones @MatheusZuchiBalbinot @Dovyski