Support for RxJS 6, Angular 6 #72

Nosfistis · 2018-05-09T09:36:42Z

Currently it is not possible to use this with Angular 6 since the rxjs operators follow the old 'rxjs/add/operator/' syntax. It has been deprecated and in RxJS 6 it is now removed, making the migration impossible.

Any chance to update imports? This should be trivial, but might drop some Angular 4 support.

optimistex · 2018-05-25T08:01:15Z

Addon from the user @ChandraTerli
#6 (comment)
And below on the topic...

Nosfistis · 2018-05-25T08:40:36Z

I bypassed this issue using rxjs-compat for now, which is supposed to provide migration until RxJS 7.

optimistex · 2018-05-25T08:45:26Z

Cool. You are have the solution and I have more time to put this enhance in my schedule.

rlefever68 · 2018-05-30T22:52:25Z

rxjs-compat is not working for me, unfortunately. I get " Fatal Error this.subjExternalValue.map is not a function".. using rxjs-compat 6.2.0

scotteby · 2018-05-31T20:56:31Z

I get the same error as @rlefever68, but only when I run in production mode.

In dev mode, I don't get any errors with rxjs-compat 6.2.0

optimistex · 2018-06-20T03:11:45Z

Today I upgraded my general project and I don't note any issues between the ngx-select-ex and Angular 6.
Now I have installed "rxjs-compat": "^6.2.1".

Looks like the issue is not actual. Closed.

If it is still actual let me know how to reproduce it.
Just check the example: https://stackblitz.com/edit/ngx-select-ex-example-formcontrol-ng6?file=app/app.component.ts
Fork it and show the issue.

Nosfistis · 2018-06-20T12:14:11Z

The issue is still valid. I have v3.5.9 installed and the imports do not comply with rxjs v6.

rxjs-compat is supposed to be a stepping stone before completely moving to rxjs v6, and it will not work on rxjs v7. You can check more details about the migration here: https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md

If needed I can issue a PR with the required changes.

scotteby · 2018-06-20T12:41:44Z

Did you try running in production mode? I still get errors as of yesterday in production mode.

…

On Wed, Jun 20, 2018 at 8:14 AM Mike Drakoulelis ***@***.***> wrote: The issue is still valid. I have v3.5.9 installed and the imports do not comply with rxjs v6. rxjs-compat is supposed to be a stepping stone before completely moving to rxjs v6, and it will not work on rxjs v7. You can check more details about the migration here: https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md If needed I can issue a PR with the required changes. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATjYPkHSUn_YvGQl9Ycs7sp8_EaMYK8aks5t-jyXgaJpZM4T4Ant> .

optimistex · 2018-06-20T12:45:53Z

I build so ng build and already use in production.
All it is ok.

But. The component is still on Angular 5. Little late I'll upgrade it for Angular 6.

Currently, I do not see the issue.

Nosfistis · 2018-06-20T13:33:43Z

For a quick adjustment (although this is an easy transition) you can list rxjs-compat in the dependencies list of the module in package.json, so that it is installed.

scotteby · 2018-06-21T13:18:03Z

@optimistex , I'm using webpack, not ngbuild, and webpack in production mode gives me the error I mentioned earlier. I created a test project using ng build and noticed I don't see the errors.

I will track down the exact webpack configuration issue causing this, but we will still need a code change so that we can eventually remove the rxjs-compat library and have proper rxjs 6 support. Thanks for testing it.

scotteby · 2018-06-21T15:14:24Z

Just in case anyone is trying to get this working with Webpack 4, you need to disable the sideEffects optimization in production mode.

optimization: { sideEffects: false }

galvakojis · 2018-07-10T14:29:12Z

ERROR in node_modules/ngx-select-ex/ngx-select/ngx-select.component.d.ts(4,10): error TS2305: Module '"/frontend/project/node_modules/rxjs/BehaviorSubject"' has no exported member 'BehaviorSubject'.
frontend_1    | node_modules/rxjs/BehaviorSubject.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/BehaviorSubject'.

Maybe any ideas, how to resolve it?
change this
import { BehaviorSubject } from 'rxjs/BehaviorSubject';

to this?
import {BehaviorSubject} from "rxjs/index";

pktron · 2018-07-31T00:53:16Z

rxjs compatibility worked for me...
npm install --save rxjs-compat

But is gonna be deprecated on rxjs 7...

queejie · 2018-08-21T17:22:02Z

Can you let folks know when it is ready for rxjs 6, without the rxjs-compat module? Thank you.

ravenwill · 2018-09-03T20:22:18Z

I'm using rxjs-compat module but i have this error in console

ERROR TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_5__.Observable.from is not a function
at MergeMapSubscriber.project (ngx-select-ex.es5.js:250)

Redlobster74 · 2018-09-06T13:58:07Z

@optimistex the solution from @galvakojis fixes the compilation issue when rxjs-compat isn't used.
To be more precise I would change that line into:

import {BehaviorSubject} from "rxjs";

Is there any chance you can push this small update so everybody can start use your library without rxjs-compat?

prikryl · 2018-09-18T08:34:24Z

@ravenwill
downgrade compat library. It seems to be broken

    "rxjs": "^6.3.2",
    "rxjs-compat": "6.2.2",

Disane87 · 2018-09-18T15:18:46Z

@ravenwill
downgrade compat library. It seems to be broken
    "rxjs": "^6.3.2",
    "rxjs-compat": "6.2.2",

This solved our problems with the error ERROR TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_5__.Observable.from is not a function at MergeMapSubscriber.project (ngx-select-ex.es5.js:250) too

DanniB · 2018-09-18T17:31:48Z

Please fix this. I want to get rid of rxjs-compat. Otherwise, I'm forced to switch to ng-select:

https://github.com/ng-select/ng-select

Stan92 · 2018-09-24T06:15:23Z


  "rxjs": "^6.3.2",
  "rxjs-compat": "6.2.2",

Doesn't work for me.

sabariU · 2018-09-27T02:27:57Z

@ravenwill
downgrade compat library. It seems to be broken
    "rxjs": "^6.3.2",
    "rxjs-compat": "6.2.2",

It works for me. Thanks

optimistex · 2018-10-28T11:21:13Z

The component has upgraded in the 3.6.1 release to the latest Angular: https://github.com/optimistex/ngx-select-ex/releases/tag/3.6.1

prikryl · 2018-10-28T12:27:36Z

you are still using compat package, which you should not, if code is fully migrated to rxjs6.
https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md
"rxjs-compat": "^6.3.3",

this causes:

ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/observable/empty' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/observable/from' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/observable/of' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/combineLatest' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/distinctUntilChanged' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/do' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/filter' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/map' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/merge' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/mergeMap' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/share' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
ERROR in ./node_modules/ngx-select-ex/fesm5/ngx-select-ex.js
Module not found: Error: Can't resolve 'rxjs/add/operator/toArray' in 'C:\dev\workspace\idea\xxxx-slot-4\xxxx\xxxx-static\node_modules\ngx-select-ex\fesm5'
i ｢wdm｣: Failed to compile.

Could you remove this dependency and migrate code to RxJS6 ?

prikryl · 2018-10-30T16:44:29Z

I have tried to create pull request (I don't known if it is correct to use fork and pull request). valor-software#971
Could you check it? I fixed imports and switchted to pipes om few lines and package.json.
Thank you

optimistex · 2018-10-30T18:38:44Z

@prikryl Fixed in the development version. Soon will be in a release...
Try it: npm i ngx-select-ex@dev

I have tried to create pull request (I don't known if it is correct to use fork and pull request). valor-software#971
Could you check it? I fixed imports and switchted to pipes om few lines and package.json.
Thank you

You have to make a pull request into my fork.
By the way, I did the changes... So, you can check and let me know if something wrong.

This was referenced May 25, 2018

Ensure compatible with Angular 6 #76

Closed

Meta version mismatch. // Solution: npm i ngx-select-ex@ng4 #6

Closed

optimistex added enhancement important The important task labels May 25, 2018

optimistex closed this as completed Jun 20, 2018

optimistex reopened this Jun 20, 2018

optimistex closed this as completed Oct 28, 2018

optimistex reopened this Oct 28, 2018

optimistex closed this as completed Oct 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for RxJS 6, Angular 6 #72

Support for RxJS 6, Angular 6 #72

Nosfistis commented May 9, 2018

optimistex commented May 25, 2018

Nosfistis commented May 25, 2018

optimistex commented May 25, 2018

rlefever68 commented May 30, 2018

scotteby commented May 31, 2018

optimistex commented Jun 20, 2018 •

edited

Loading

Nosfistis commented Jun 20, 2018

scotteby commented Jun 20, 2018 via email

optimistex commented Jun 20, 2018

Nosfistis commented Jun 20, 2018

scotteby commented Jun 21, 2018

scotteby commented Jun 21, 2018

galvakojis commented Jul 10, 2018 •

edited

Loading

pktron commented Jul 31, 2018

queejie commented Aug 21, 2018

ravenwill commented Sep 3, 2018 •

edited

Loading

Redlobster74 commented Sep 6, 2018 •

edited

Loading

prikryl commented Sep 18, 2018

Disane87 commented Sep 18, 2018

DanniB commented Sep 18, 2018

Stan92 commented Sep 24, 2018

sabariU commented Sep 27, 2018

optimistex commented Oct 28, 2018 •

edited

Loading

prikryl commented Oct 28, 2018 •

edited

Loading

prikryl commented Oct 30, 2018 •

edited

Loading

optimistex commented Oct 30, 2018 •

edited

Loading

Support for RxJS 6, Angular 6 #72

Support for RxJS 6, Angular 6 #72

Comments

Nosfistis commented May 9, 2018

optimistex commented May 25, 2018

Nosfistis commented May 25, 2018

optimistex commented May 25, 2018

rlefever68 commented May 30, 2018

scotteby commented May 31, 2018

optimistex commented Jun 20, 2018 • edited Loading

Nosfistis commented Jun 20, 2018

scotteby commented Jun 20, 2018 via email

optimistex commented Jun 20, 2018

Nosfistis commented Jun 20, 2018

scotteby commented Jun 21, 2018

scotteby commented Jun 21, 2018

galvakojis commented Jul 10, 2018 • edited Loading

pktron commented Jul 31, 2018

queejie commented Aug 21, 2018

ravenwill commented Sep 3, 2018 • edited Loading

Redlobster74 commented Sep 6, 2018 • edited Loading

prikryl commented Sep 18, 2018

Disane87 commented Sep 18, 2018

DanniB commented Sep 18, 2018

Stan92 commented Sep 24, 2018

sabariU commented Sep 27, 2018

optimistex commented Oct 28, 2018 • edited Loading

prikryl commented Oct 28, 2018 • edited Loading

prikryl commented Oct 30, 2018 • edited Loading

optimistex commented Oct 30, 2018 • edited Loading

optimistex commented Jun 20, 2018 •

edited

Loading

galvakojis commented Jul 10, 2018 •

edited

Loading

ravenwill commented Sep 3, 2018 •

edited

Loading

Redlobster74 commented Sep 6, 2018 •

edited

Loading

optimistex commented Oct 28, 2018 •

edited

Loading

prikryl commented Oct 28, 2018 •

edited

Loading

prikryl commented Oct 30, 2018 •

edited

Loading

optimistex commented Oct 30, 2018 •

edited

Loading