Skip to content

Conversation

fscelliott
Copy link
Contributor

Summary

  • as tech writer editing Kody's agent docs, I'm editing the API docs as part of Agent launch. I didn't build Agent locally but I did run my changes through 2 validators (swagger-editor and yaml-lint)

Issues

Copy link
Contributor Author

@fscelliott fscelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments:
-sorry, is there a prettifier or something I should run to avoid the long lines I've created here?

  • don't quite get the JWT endpoint --- where are you configuring expiration/sdk? is it reflected in the datafile? Is "Optimizely config" endpoint a subset of the datafile, or the datafile itself...?

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #208 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          27       27           
  Lines        1241     1241           
=======================================
  Hits         1021     1021           
  Misses        165      165           
  Partials       55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cab7bb...9a96724. Read the comment docs.

Co-Authored-By: JC <40373238+juancarlostong@users.noreply.github.com>
@fscelliott
Copy link
Contributor Author

fscelliott commented Apr 10, 2020

@juancarlostong I merged your suggestion. Are you ready to approve?

Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fscelliott fscelliott merged commit 0f1e002 into master May 1, 2020
@fscelliott fscelliott deleted the docs-api branch May 1, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants