(fix)wrap schedule in a try catch in case of too many scheduled jobs which… #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throws an exception
thomaszurkan-optimizely
requested review from
mikeproeng37 and
msohailhussain
mikeproeng37
suggested changes
Nov 8, 2018
| } | ||
| } | ||
| catch (Exception e) { | ||
| logger.error("Problem scheduling job ", e); |
There was a problem hiding this comment.
We should probably provide more context on this error, like the fact that the datafile sync scheduling failed.
There was a problem hiding this comment.
I added the component name which would in this case be DatafileService
thomaszurkan-optimizely
added a commit
that referenced
this pull request
Nov 8, 2018
…which… (#236) * wrap schedule in a try catch in case of too many scheduled jobs which throws an exception * added better logging and exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… throws an exception
wrap the job scheduler schedule in a try catch. Customer is experiencing difficulty starting in the background and trying to schedule another background update causes a Illegal State Exception.
This is not necessarily the SDK's fault but the exception should not stop the app. So, we are wrapping the call with a try catch.
#234