(fix):potential fix for multi scheduling of event work #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
changed the title
jophde
approved these changes
Apr 22, 2019
| @@ -101,8 +101,10 @@ void reschedule(@NonNull Context context, @NonNull Intent broadcastIntent, @NonN | |||
| // with wifi the service will be rescheduled on the interval. | |||
| // Wifi connection state changes all the time and starting services is expensive | |||
| // so it's important to only do this if we have stored events. | |||
| ServiceScheduler.startService(context, EventIntentService.JOB_ID, eventServiceIntent); | |||
| logger.info("Preemptively flushing events since wifi became available"); | |||
| if (android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.O) { | |||
There was a problem hiding this comment.
Why not schedule on Android O?
There was a problem hiding this comment.
I'm adding a comment. But, it is because in Android O and higher, we use the job scheduler and make the job persistent. this means that it will restart itself.
thomaszurkan-optimizely
added a commit
that referenced
this pull request
Apr 23, 2019
* potential fix for multi scheduling of event work * add a comment why not restarting in event rescheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues