Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix):refactor the try catch for failing to load logger #270

Merged
merged 1 commit into from
Apr 23, 2019
Merged

(fix):refactor the try catch for failing to load logger #270

merged 1 commit into from
Apr 23, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • Cleanup the try catch error for logging.

Issues

mikeproeng37
mikeproeng37 approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit c4bb4f9 into master Apr 23, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the cleanupSecurityErrorCatching branch April 23, 2019 20:11
thomaszurkan-optimizely added a commit that referenced this pull request Apr 23, 2019
@thomaszurkan-optimizely
refactor the try catch for failing to load logger (#270)
edade96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaszurkan-optimizely @mikeproeng37