(fix): Listener on task #321
Merged
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…postExecute since file io can take some time.
thomaszurkan-optimizely
requested review from
jaeopt,
mikeproeng37 and
mnoman09
jaeopt
requested changes
Feb 28, 2020
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
A fix for async init thread changes datafile loading for sync init.
Comment on lines
288
to
293
| // if (isDatafileCached(context)) { | ||
| // String datafile = datafileHandler.loadSavedDatafile(context, datafileConfig); | ||
| // if (datafile != null) { | ||
| // return datafile; | ||
| // } | ||
| // } |
Contributor
There was a problem hiding this comment.
It looks like this function is shared for sync and async init. I see you move this to async download thread. It looks great.
This will change sync init behavior (it'll skip cache load) if we remove it. We probably need a separate path for sync and async for getDatafile().
…source on main thread if all else fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues