Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate android.support libraries to androidx #328

Closed
wants to merge 3 commits into from

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 6, 2020

Summary

  • Migrate android.support libraries to androidx

@jaeopt jaeopt requested a review from a team as a code owner April 6, 2020 23:57
@jaeopt jaeopt added the chore label Apr 10, 2020
@yogurtearl
Copy link

@jaeopt do you have plans to get this merged soon?
do you want any assistance with this androidx PR?

@jaeopt
Copy link
Contributor Author

jaeopt commented Jul 29, 2020

@yogurtearl Thanks for the offer. We're holding it for applications still using the legacy support libraries. Do you see any issues using the SDK and need us to migrate to androidx?

@yogurtearl
Copy link

@jaeopt we need it to be upgraded so that we can turn off jetifier in our app, which slows down our build times.

If an app hasn't upgraded to AndroidX in the last 2 years, they probably will stick with the old version of the optimizely sdk as well. :)
Legacy apps can still continue to use your previously published SDKs that use the deprecated dependencies.

@jaeopt
Copy link
Contributor Author

jaeopt commented Jul 30, 2020

@yogurtearl It's a good point. Thanks!

@yogurtearl
Copy link

@jaeopt so... can we get this merged for an upcoming release? 😬

@jaeopt
Copy link
Contributor Author

jaeopt commented Jul 30, 2020

@yogurtearl Cannot promise that but we'll look into it with your input.

@jnell-godaddy
Copy link

Another option here could be to publish a -jetified and a legacy dependency so that developers can have the choice 😀

This is the approach other libraries like https://github.com/Appboy/appboy-android-sdk have taken.

@technoir42
Copy link

technoir42 commented Sep 15, 2020

Please consider this for the next release. Optimizely is literally the last library out of several dozen in our project which hasn't been migrated to AndroidX yet.
We, users, just want to turn off Jetifier and enjoy improved build times. Why harm the experience of the vast majority because of a few users which haven't migrated from the support library and might never do so? They can continue using the old version of the library, or if they absolutely need new features they can de-jetify the SDK.

@jaeopt
Copy link
Contributor Author

jaeopt commented Sep 16, 2020

@technoir42 Thanks for your input. A good point. It'll be considered.

@kozaxinan
Copy link

kozaxinan commented Oct 1, 2020

Version3.7 is released without AndroidX support. Optimizely one of last two libraries to drop Jetifier for us. Is there a timeline for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants