Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getFeatureVariableJSON and getAllFeatureVariables apis #337

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 2, 2020

Summary

  • add new APIs (getFeatureVariableJSON, getAllFeatureVariables)

  • add new notification type (all-feature-variables)

  • Add mavenLocal() to supported repositories for local development

  • Bump core SDK to 3.5.0-beta

  • Added unit tests

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address.
Also add test cases for getValue as well.

build.gradle Outdated
@@ -45,6 +45,7 @@ allprojects {
repositories {
jcenter()
google()
mavenLocal()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be commented out and only enabled manually by whoever is running locally. Just leave a comment in there about it

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnoman09 mnoman09 removed their assignment Jul 10, 2020
@jaeopt jaeopt closed this Jul 10, 2020
@jaeopt jaeopt reopened this Jul 10, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 083d445 into master Jul 10, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the mnoman/featJsonAllFeat branch July 10, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants