-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getFeatureVariableJSON and getAllFeatureVariables apis #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address.
Also add test cases for getValue as well.
- Bump core SDK to 3.5.0-beta
build.gradle
Outdated
@@ -45,6 +45,7 @@ allprojects { | |||
repositories { | |||
jcenter() | |||
google() | |||
mavenLocal() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be commented out and only enabled manually by whoever is running locally. Just leave a comment in there about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
add new APIs (getFeatureVariableJSON, getAllFeatureVariables)
add new notification type (all-feature-variables)
Add mavenLocal() to supported repositories for local development
Bump core SDK to 3.5.0-beta
Added unit tests