New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: upgrade the androidx and get all tests passing #356

Merged

thomaszurkan-optimizely merged 11 commits into master from migrateAndroidX

Jan 8, 2021

Contributor

thomaszurkan-optimizely commented Jan 4, 2021 •

edited

Loading

Summary

Upgraded to androidx. Fixed all unit tests that either didn't compile or failed.
Still need to update to the WorkManager and remove our job services.

Test plan

lots of manual testing as well as travis and unit tests.

Issues


          upgrade the androidx and get all tests passing

3b56c21

thomaszurkan-optimizely requested a review from a team as a code owner

January 4, 2021 23:07

optimizely-codereview-bot assigned thomaszurkan-optimizely

thomaszurkan-optimizely added the chore label

thomaszurkan-optimizely added 5 commits

January 4, 2021 15:24


          shared library cannot have compile only for android x calls since the…

… app might not be android x


          include android x libraries as implementation:

0fe47d1


          increase thread pool to 5

9118c2e


          increase executor to 10 threads for user profile cache tests on travis

6eec4ec


          try and get user profile cache test to pass. It was just chance that …

709edbf

…it ever passed.

thomaszurkan-optimizely closed this

thomaszurkan-optimizely reopened this


          move the annotations for travis build

8f78a38

thomaszurkan-optimizely removed the chore label


          use variables for gradle lib versions

8427a40

yogurtearl reviewed

View reviewed changes

android-sdk/build.gradle Outdated Show resolved Hide resolved

yogurtearl reviewed

View reviewed changes

...ler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileServiceTest.java Outdated Show resolved Hide resolved

yogurtearl reviewed

View reviewed changes

...ler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileServiceTest.java Outdated Show resolved Hide resolved

yogurtearl reviewed

View reviewed changes

test-app/build.gradle Outdated Show resolved Hide resolved


          remove guava

b01cd22

thomaszurkan-optimizely removed their assignment

yogurtearl reviewed

View reviewed changes

...dler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileLoaderTest.java Outdated Show resolved Hide resolved


          remove androidx internal dep

5caf0e7

optimizely-codereview-bot added the 🤖 4 hrs label


          update to latest libs

c1ee072

thomaszurkan-optimizely closed this

thomaszurkan-optimizely reopened this

optimizely-codereview-bot assigned thomaszurkan-optimizely

optimizely-codereview-bot removed the 🤖 4 hrs label

thomaszurkan-optimizely closed this

thomaszurkan-optimizely reopened this

thomaszurkan-optimizely requested a review from msohailhussain

January 8, 2021 02:15

msohailhussain approved these changes

View reviewed changes

Contributor

msohailhussain left a comment

lgtm

thomaszurkan-optimizely merged commit b0123c3 into master

thomaszurkan-optimizely deleted the migrateAndroidX branch

January 8, 2021 18:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet