Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove erroneous error if project id and sdk key are null. #358

Merged
merged 2 commits into from
Jan 26, 2021
Merged

fix: remove erroneous error if project id and sdk key are null. #358

merged 2 commits into from
Jan 26, 2021

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jan 25, 2021 •
edited
Loading

Summary

  • move check to datafileConfig check.
  • simple change.

Tests

  • Added unit tests to builder test.

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner January 25, 2021 21:15
jaeopt
jaeopt approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 4704fed into master Jan 26, 2021
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fixConfigIssue branch January 26, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptimizelyManager Builder requires projectId or sdkKey
2 participants
@thomaszurkan-optimizely @jaeopt