Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OptimizelyConfig): add new fields to OptimizelyConfig #379

Merged
merged 7 commits into from
Aug 26, 2021
Merged

fix(OptimizelyConfig): add new fields to OptimizelyConfig #379

merged 7 commits into from
Aug 26, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Aug 19, 2021 •
edited
Loading

Summary

The following new public properties are added to OptimizelyConfig (from java-sdk core):

  • sdkKey
  • environmentKey
  • attributes
  • audiences
  • events
  • experimentRules and deliveryRules to OptimizelyFeature
  • audiences to OptimizelyExperiment

@jaeopt jaeopt requested a review from a team as a code owner August 19, 2021 23:45
@jaeopt jaeopt closed this Aug 20, 2021
@jaeopt jaeopt reopened this Aug 20, 2021
@jaeopt jaeopt closed this Aug 23, 2021
@jaeopt jaeopt reopened this Aug 23, 2021
The-inside-man
The-inside-man approved these changes Aug 23, 2021
View reviewed changes
Copy link

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Aug 25, 2021
@jaeopt jaeopt reopened this Aug 25, 2021
@jaeopt jaeopt merged commit 97298b8 into master Aug 26, 2021
@jaeopt jaeopt deleted the jae/optconfig2 branch August 26, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-inside-man The-inside-man The-inside-man approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeopt @The-inside-man