Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(Reachability): add connection checking for datafile-fetch and event-dispatch #389

Merged
merged 19 commits into from
Nov 15, 2021
Merged

feature(Reachability): add connection checking for datafile-fetch and event-dispatch #389

merged 19 commits into from
Nov 15, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Nov 8, 2021

Summary

  • Add connection constraints to WorkManager requests for datafile-fetch and event-dispatch
  • Fix default event-dispatch retry to disabled (configurable)

Test plan

  • Unit tests for DatafileWorker and EventWorker
  • Manual tests with devices

Issues

  • OASIS-8025

@jaeopt jaeopt requested a review from a team as a code owner November 8, 2021 21:55
@jaeopt jaeopt removed their assignment Nov 9, 2021
The-inside-man
The-inside-man approved these changes Nov 9, 2021
View reviewed changes
Copy link

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small comment.

mnoman09
mnoman09 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good just some headers are missing and some needs to be updated. Otherwise everything LGTM.

...dler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileWorkerTest.java Show resolved Hide resolved
event-handler/src/androidTest/java/com/optimizely/ab/android/event_handler/EventWorkerTest.java Outdated Show resolved Hide resolved
shared/src/androidTest/java/com/optimizely/ab/android/shared/WorkerSchedulerTest.java Show resolved Hide resolved
@jaeopt jaeopt merged commit 02bc421 into master Nov 15, 2021
@jaeopt jaeopt deleted the jae/reachability branch November 15, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoman09 mnoman09 mnoman09 approved these changes

@The-inside-man The-inside-man The-inside-man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @The-inside-man @mnoman09