Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ATS): add vuid manager #431

Merged
merged 17 commits into from
Dec 16, 2022
Merged

feat(ATS): add vuid manager #431

merged 17 commits into from
Dec 16, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 12, 2022 •
edited
Loading

Summary

Add VuidManager which will create and manage a vuid:

  • create a random vuid if it cannot be found in the device with the required format.
  • "vuid_" + 32 hexadecimal string (UUID with all "-"s removed).
  • all lowercases ("vuid_330e05cad15746d9af8a75b8d1050a87")
  • SDK will reuse the same vuid (saving to and retrieving from a persistent storage when the client application starts).
  • SDK will support a single vuid shared by multiple SDK instances (thread-safe)
  • ODP module added

Test plan

  • add unit tests

Issues

@jaeopt jaeopt requested a review from a team as a code owner September 12, 2022 18:34
@jaeopt jaeopt removed their assignment Sep 12, 2022
opti-jnguyen
opti-jnguyen suggested changes Sep 23, 2022
View reviewed changes
Copy link

@opti-jnguyen opti-jnguyen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM besides the probable typo with shered.

Food for thought - what do you think about abstracting out VUID as its own class, separate from VUIDManager?

Was fun re-visiting Kotlin!

@jaeopt jaeopt requested a review from opti-jnguyen September 23, 2022 20:32
@jaeopt jaeopt removed their assignment Sep 23, 2022
@jaeopt jaeopt requested a review from a team September 26, 2022 17:48
opti-jnguyen
opti-jnguyen approved these changes Sep 26, 2022
View reviewed changes
Copy link

@opti-jnguyen opti-jnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Nov 18, 2022
@jaeopt jaeopt reopened this Nov 18, 2022
@jaeopt jaeopt removed their assignment Dec 16, 2022
@jaeopt jaeopt merged commit 971761e into master Dec 16, 2022
@jaeopt jaeopt deleted the jae/odpVuidManager branch December 16, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opti-jnguyen opti-jnguyen opti-jnguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @opti-jnguyen @optimizely-codereview-bot