fix(ATS): send an internal notification when project config is updated #448
Conversation
| return; | ||
| } | ||
|
|
||
| String sdkKey = config.getSdkKey(); |
There was a problem hiding this comment.
There is a corner case in which this will cause a problem. That when sdkKey is not in the datafile but is used to fetch datafile from a custom URL?
There was a problem hiding this comment.
I am not sure if this is a valid scenario for android or not but we handled it in java-sdk.
There was a problem hiding this comment.
@mnoman09 A good point. This line is for after fetching remote datafile. Some CDN (or proxy server) datafiles of old projects may miss sdkKeys but those are obviously not using ODP integrations, so must be safe. I mean if they want to integrate ODP then it's expected to have sdkKey in the datafile too.
There was a problem hiding this comment.
I got your point but I think even if the sdkKey exist in the datafile it can still cause the problem when the sdkKey used to download the datafile is different then what is in the datafile (Like we are doing in FSC using proxy server and using custom temporary sdkKeys). Notification will not trigger in that scenario.
In order to keep it consistent we need to somehow use the sdkKey which is used in NotificationRegistry (which is passed by user).
| @@ -946,4 +947,34 @@ NotificationCenter getNotificationCenter() { | |||
|
|
|||
| return null; | |||
| } | |||
|
|
|||
| void sendUpdateConfigNotification() { | |||
There was a problem hiding this comment.
Is this the function that we are going to expose to public or not? If yes then we should add public.
There was a problem hiding this comment.
We do not need to open to public. This one includes internal notification handling in addition to already-existing public notification interface.
Summary
Test plan
Issues