Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8952] doc: Full Stack to Feature Experimentation Rename #450

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Update instances of Full Stack to Feature Experimentation
  • Reformat README

Test plan

  • Existing unit tests & FSC e2e tests should pass

Issues

  • FSSDK-8952

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -110,7 +112,7 @@ You can import this project into Android Studio by opening Android Studio and se

Tests can be run by right clicking the file in the project pane or by clicking the method name in source and selecting run. You will be prompted to create an AVD or connect a device if one isn't connected.

### Contributing
## Contributing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Contributing
## SDK Development
### Contributing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this heading is already getting used at line 85, should I move it here? and then what should be the heading at line 85?

build.gradle Outdated Show resolved Hide resolved
test-app/build.gradle Outdated Show resolved Hide resolved
@mnoman09 mnoman09 removed their assignment Mar 10, 2023
Copy link

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit 390c464 into master Mar 14, 2023
@mnoman09 mnoman09 deleted the mnoman/fx-rename branch March 14, 2023 19:57
mnoman09 added a commit that referenced this pull request Mar 14, 2023
* [FSSDK-8952] doc: Full Stack to Feature Experimentation Rename

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
(cherry picked from commit 390c464)
mnoman09 added a commit that referenced this pull request Mar 16, 2023
* fix(EventRescheduler): catch exception for event service restart (#446)

(cherry picked from commit 585f099)

* [FSSDK-8952] doc: Full Stack to Feature Experimentation Rename (#450)

* [FSSDK-8952] doc: Full Stack to Feature Experimentation Rename

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
(cherry picked from commit 390c464)

* changed java version to 3.10.3

* [FSSDK-8952] chore: prepare for release 3.13.4 (#452)

* chore: prepare for release 3.13.4

* set java core version to 3.10.3

* removed comment

* Revert "removed comment"

This reverts commit a326808.

* Revert "set java core version to 3.10.3"

This reverts commit fe586f6.

---------

(cherry picked from commit cbcdd1e)

---------

Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants